Plug a memory leak
authorMatthias Clasen <mclasen@redhat.com>
Mon, 25 Sep 2017 01:34:53 +0000 (21:34 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 25 Sep 2017 01:48:07 +0000 (21:48 -0400)
A function with ensure in the name would better check if the
thing it is supposed to ensure already exists.

gsk/gskvulkanimage.c

index 2540d8a58cc1796a057087aaffe07e112e48530b..d09a109e52f9ca76a7ead2ca587bce4eacd96bc3 100644 (file)
@@ -299,7 +299,8 @@ static void
 gsk_vulkan_image_ensure_view (GskVulkanImage *self,
                               VkFormat        format)
 {
-  GSK_VK_CHECK (vkCreateImageView, gdk_vulkan_context_get_device (self->vulkan),
+  if (self->vk_image_view == VK_NULL_HANDLE)
+    GSK_VK_CHECK (vkCreateImageView, gdk_vulkan_context_get_device (self->vulkan),
                                    &(VkImageViewCreateInfo) {
                                        .sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO,
                                        .image = self->vk_image,